Fix focus_follows_mouse switching active window on desktop return - #9873
Closed
lxcode wants to merge 1 commit into
Closed
Fix focus_follows_mouse switching active window on desktop return#9873lxcode wants to merge 1 commit into
lxcode wants to merge 1 commit into
Conversation
When returning to a desktop/space, enter_event fires and detects the window under the cursor, triggering focus_follows_mouse to switch focus even though the mouse didn't cross a window boundary. Add a focus_follows parameter to set_currently_hovered_window so enter_event can update hover state without triggering focus switching. Normal mouse motion still switches focus on boundary crossings as before.
Owner
|
There is no guarantee that enter_event() is not from a mouse motion. |
Contributor
Author
|
Gotcha, thanks. Yeah, i can't think of a way to address that without including more complexity than it's probably worth, given it's a tiny issue. Feel free to close out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When returning to a desktop/space, enter_event fires and detects the window under the cursor, triggering focus_follows_mouse to switch focus even though the mouse didn't cross a window boundary. Add a focus_follows parameter to set_currently_hovered_window so enter_event can update hover state without triggering focus switching. Normal mouse motion still switches focus on boundary crossings as before.